Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load MathJax's text-chtml-full component in reviewer/previewer #2836

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

abdnh
Copy link
Collaborator

@abdnh abdnh commented Nov 18, 2023

Loading the tex-chtml-full component in the review/preview screens results in the same TeX extensions as in the editor being loaded (where tex-svg-full is used).

image

Closes #1773

@dae
Copy link
Member

dae commented Nov 20, 2023

I used the inspector to profile the speed difference, and it brings the ~85ms script load to ~100ms on my (fast) system, which is not ideal, but not terrible, either. Auto-loading might be a way to avoid the extra cost in the future, but this will at least move things in the right direction. Something else that might be looking into as a follow-up: the editor is using text-svg-full, and we're using text-chtml-full in the reviewer. Maybe we could switch the editor to chtml as well?

@dae dae merged commit e88dfb6 into ankitects:main Nov 20, 2023
@abdnh abdnh deleted the mathjax-exts branch November 20, 2023 07:47
@abdnh
Copy link
Collaborator Author

abdnh commented Nov 21, 2023

the editor is using text-svg-full, and we're using text-chtml-full in the reviewer. Maybe we could switch the editor to chtml as well?

Looks like it's not very simple. One issue is that the CSS doesn't get loaded automatically.

@dae
Copy link
Member

dae commented Nov 23, 2023

Thanks for looking into it. It looks like the opposite - switching the reviewer to svg - would work, but as it may possibly cause other regressions, probably best to leave things as they are for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify exposed MathJax add-ons
2 participants