Fix filtered deck ordering of intraday learning cards and reviews #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdnh
commented
Nov 14, 2023
rslib/src/scheduler/filtered/mod.rs
Outdated
| @@ -121,7 +121,7 @@ impl Collection { | |||
| format!("({})", term.search) | |||
| } | |||
| ); | |||
| let order = order_and_limit_for_search(term, ctx.today); | |||
| let order = order_and_limit_for_search(term, ctx.today, self.storage.creation_stamp()?.0); | |||
There was a problem hiding this comment.
I believe this is only 100% accurate in V1, and we need to get this from the SchedTimingToday calculations in timing.rs instead?
There was a problem hiding this comment.
Yes, the current approach won't handle the rollover correctly. Please use .days_elapsed instead (eg (due - {days_elapsed}) * 86400 + {current_timestamp})
|
Thanks Abdo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2812