Allow im-/exporting with or without deck configs #2804
Conversation
|
Just realized that we only import new configs. Should I implement updating existing ones? Otherwise, we should probably at least mention that limitation in the help string. |
|
Thanks Rumo, I'll circle back to this after 23.10.1 is out the door. Let's skip updating unless someone makes a strong case for it, as I imagine it will cause people to think Anki is at fault when they update a deck and suddenly they're getting things like a different number of new cards a day. |
|
New cards per day may already change, though, because the deck itself is getting updated (things like |
|
Don't we handle that in prepare_deck()? |
|
(though we still need to de-couple 'contains scheduling' and 'include scheduling' - can't remember if I previously pointed ceb8a4a out to you) |
|
Ah, just skimmed through your changes (hadn't looked at them yet) - I see you're now doing that based on include_config. Would it make sense to revert that part to being based on scheduling, and make a rule that deck authors can only adjust the limits in their template, and not on individual decks? We could think of the option as 'include preset' rather than 'include config' to make it clearer, and it would ensure we don't accidentally import the deck's current review count for the day if the exporter included scheduling and the importer didn't. It would also make it easier for importers to override the default daily limits if we implemented updating in the future. |
I was also considering that, but couldn't decide and opted for the (slightly) simpler alternative. I will change it.
Funny you mention it. I see I've accidentally dropped the reset of |
Also: - Fix `deck.common` not being reset. - Apply all logic only depending on the source collection in the gathering stage. - Skip checking for scheduling and only act based on whether the call wants scheduling. Preservation of filtered decks also depends on all original decks being included. - Fix check_ids() not covering revlog.
RumovZ
force-pushed
the
import-deck-configs
branch
from
8087916 to
6639657
Compare
|
Thanks Rumo! |
| with_scheduling: bool, | ||
| with_media: bool, | ||
| legacy_support: bool, | ||
| self, *, out_path: str, options: ExportAnkiPackageOptions, limit: ExportLimit | ||
| ) -> int: |
There was a problem hiding this comment.
(musing to myself: this is an API break. Given that, and we're adding new features, this next update might be better called 23.12 than 23.10.2)
Closes #2777.