Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylebot 3.0 breaks cnet.com #562

Closed
raypaw opened this issue Jul 30, 2020 · 2 comments
Closed

Stylebot 3.0 breaks cnet.com #562

raypaw opened this issue Jul 30, 2020 · 2 comments
Labels
bug Bug report resolved

Comments

@raypaw
Copy link

raypaw commented Jul 30, 2020 •
edited
Loading

When Stylebot 3.0 is enabled, the CNET website breaks in the users local browser. Two ways this manifests is that ads don't display and an error is seen in the console.

Verified in a fresh Chrome profile with no other extensions.

Stylebot disabled:
stylebot-disabled

Stylebot enabled
stylebot-enabled
@ankit ankit added bug Bug report fix in progress Prioritized and actively working on fixing this bug labels Jul 30, 2020
@ankit
Copy link
Owner

ankit commented Jul 30, 2020 •
edited
Loading

@raypaw thanks for reporting, i will work on a bugfix. The actual JS error in the console is actually coming from the site.

@raypaw
Copy link
Author

raypaw commented Jul 30, 2020

@ankit congratulations on 3.0 and thanks for the great extension!

ankit added a commit that referenced this issue Jul 30, 2020
@ankit
only inject editor content script in the topmost frame #562 #561
9f074b9
@ankit ankit added in webstore review Release containing fix is in review in Chrome Web Store resolved and removed fix in progress Prioritized and actively working on fixing this bug in webstore review Release containing fix is in review in Chrome Web Store labels Jul 30, 2020
@ankit ankit closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug report resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankit @raypaw