Fix crash related to escaping html entites #5670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The Matcher.appendReplacement() method used when escaping html entities treats backslashes (\) and dollar signs ($) differently than the rest of the replacement string. Due to the input not being properly escaped, certain sequences (f.i. "&bsop;") lead to crashes.
Fixes
This fixes issue #5638.
Approach
We use the Matcher.quoteReplacement() helper method to escape the string.
How Has This Been Tested?
I've tested the fix multiple times using an Android 28 emulator.
Checklist
Please, go through these checks before submitting the PR.
if
statements)