-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
Previously I've been relying on a personal collection of crash bugs to test the crash dialog, but that's a poor testing experience - now we have an advanced preference area to just crash During the ACRA upgrade some branding was already broken, and the rest was lost, when I finally saw the dialog again with fresh eyes it was terrible so this puts the icon and title back
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,7 +113,8 @@ | |
resCommentPrompt = R.string.empty_string, | ||
resTitle = R.string.feedback_title, | ||
resText = R.string.feedback_default_text, | ||
resPositiveButtonText = R.string.feedback_report | ||
resPositiveButtonText = R.string.feedback_report, | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
timrae
Member
|
||
resIcon = R.drawable.logo_star_144dp | ||
) | ||
@AcraHttpSender( | ||
httpMethod = HttpSender.Method.PUT, | ||
|
4 comments
on commit da1f19c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timrae forgot this follow-on to the acra work, which just went in to 2.8. I'm working on a crash bug on that branch right now and the non-branded dialog popped up. What do you think about cherry-picking this one over there? I think we're going to need a beta2 anyway because #5011 is not resolved and I'm still working on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACRA is working though (on 2.8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is really hotfix material, but if you really want it then I guess it doesn't hurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I'll do hotfix stuff with enthusiasm, you have the battle scars so you're intuition is worth it
Is that a comma at the end of the line?