Added functionality to auto-wipe inactive records #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikey S. Chauhan <[email protected]>
|
Someone is attempting to deploy a commit to a Personal Account owned by @anirudhb on Vercel. @anirudhb first needs to authorize it. |
anirudhb
requested changes
Oct 18, 2024
Comment on lines
+600
to
+601
| record.uid_salt = "empty" | ||
| record.uid_hash = "empty hash"; |
There was a problem hiding this comment.
Alternatively, using all zeros would be okay too
Suggested change
| record.uid_salt = "empty" | |
| record.uid_hash = "empty hash"; | |
| record.uid_salt = "" | |
| // hashUser("", "") | |
| record.uid_hash = "d72c87d0f077c7766f2985dfab30e8955c373a13a1e93d315203939f542ff86e73ee37c31f4c4b571f4719fa8e3589f12db8dcb57ea9f56764bb7d58f64cf705"; |
| const now = new Date(); | ||
| const weekAgo = now.setDate(now.getDate() - 7) / 1000; | ||
| const old_published_ts = record.published_ts; | ||
| if (!old_published_ts) { |
There was a problem hiding this comment.
It would be better to check if the confession was rejected
| record: Confession, | ||
| ): Promise<boolean> { | ||
| const now = new Date(); | ||
| const weekAgo = now.setDate(now.getDate() - 7) / 1000; |
There was a problem hiding this comment.
Would be better to compare with a constant (for example 7*24*60*60*1000)
| const now = new Date(); | ||
| const weekAgo = now.setDate(now.getDate() - 7) / 1000; | ||
| recordsFetched = await repository.find({ | ||
| where: [ |
There was a problem hiding this comment.
May also be a good idea to filter out confessions that already have an empty hash/salt set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates: Entries should be wiped from the confessions DB one week after the last reply from OP
Make sure to META_CHANNEL_ID and API_SECRET before merging
Feel free to request a review if you believe there are better names for new variables or if you have suggestions for improving the implementation logic.