Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fading diagonal animations #936

Closed
wants to merge 8 commits into from
Closed

Added fading diagonal animations #936

wants to merge 8 commits into from

Conversation

vaibhav111tandon
Copy link
Contributor

Added fading animations through diagonals for both fadeIn and fadeOut

TopLeft
TopRight
BottomLeft
BottomRight

@eltonmesquita
Copy link
Collaborator

Please see https://github.com/daneden/animate.css#contributing and update this PR.
Thanks.

@vaibhav111tandon
Copy link
Contributor Author

Demo:
https://codepen.io/Vaibhav119/full/yWoYJW
and classes are in camelCase

@warengonzaga
Copy link
Member

@vaibhav111tandon these are good... @eltonmesquita we can add these animations on v4

@eltonmesquita
Copy link
Collaborator

Hey @vaibhav111tandon , thanks for the PR!
Although they are totally consistent with the fade entrances/exit, they didn't feel "natural" to me. This feel makes me ask:
Do we really need diagonal entrances/exits?
I would love to hear some opinions here...

@vaibhav111tandon
Copy link
Contributor Author

Sir,
it is your library, therefore it is totally your decision to merge this request or not, if you don't find it appropriate, it's totally ok.

@eltonmesquita
Copy link
Collaborator

@vaibhav111tandon, this is not my library, it's an open source library 😄

There were many times people showed me here that my opinion was not the best for the library and we ended up merging the PR. And as I asked before, I'm not sure, so I need some feedback to make a decision.

Any thoughts about the question I've done?

@warengonzaga
Copy link
Member

@vaibhav111tandon fyi... this is not elton's library it is an open source library there so many contributor here including me.. so that... it is a public library for everyone... for me... @eltonmesquita we can add this animations as extras or misc since it is not necessary in any animation (kind of optional animation for extra spices).

@vaibhav111tandon
Copy link
Contributor Author

@warengonzaga I think adding them as misc. will be good

@eltonmesquita
Copy link
Collaborator

Sorry for the delay, but I've changed my mind and it'll get released on v4!

You can see a preview here: https://codepen.io/eltonmesquita/full/agrYzj

@eltonmesquita
Copy link
Collaborator

BTW it's merged on the dev as you can see on 793b0ff

@vaibhav111tandon
Copy link
Contributor Author

Thank you very much 😊

@warengonzaga
Copy link
Member

@eltonmesquita @vaibhav111tandon good job guys... see you on V4

@warengonzaga
Copy link
Member

@eltonmesquita kindly close this since it is added in v4
current development progress at #1029

@warengonzaga
Copy link
Member

@daneden kindly review this and close if necessary...

@daneden daneden closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants