-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fading diagonal animations #936
Conversation
Fade in the animation diagonally
Fade in the animation diagonally
Please see https://github.com/daneden/animate.css#contributing and update this PR. |
Demo: |
@vaibhav111tandon these are good... @eltonmesquita we can add these animations on v4 |
Hey @vaibhav111tandon , thanks for the PR! |
Sir, |
@vaibhav111tandon, this is not my library, it's an open source library 😄 There were many times people showed me here that my opinion was not the best for the library and we ended up merging the PR. And as I asked before, I'm not sure, so I need some feedback to make a decision. Any thoughts about the question I've done? |
@vaibhav111tandon fyi... this is not elton's library it is an open source library there so many contributor here including me.. so that... it is a public library for everyone... for me... @eltonmesquita we can add this animations as extras or misc since it is not necessary in any animation (kind of optional animation for extra spices). |
@warengonzaga I think adding them as misc. will be good |
Sorry for the delay, but I've changed my mind and it'll get released on v4! You can see a preview here: https://codepen.io/eltonmesquita/full/agrYzj |
BTW it's merged on the |
Thank you very much 😊 |
@eltonmesquita @vaibhav111tandon good job guys... see you on V4 |
@eltonmesquita kindly close this since it is added in v4 |
@daneden kindly review this and close if necessary... |
Added fading animations through diagonals for both fadeIn and fadeOut