-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Heart-Beat animation #830
Conversation
…te classes available 👍
Nice! Thank you! |
Can this PR please be merged in a new release? |
We will review it first :) @eltonmesquita can you please have a look on this? |
Hey @daneden . I'd love to hear your opinion about this one ;D |
@eltonmesquita and @daneden actually I am using this one with the latest feature :) I agree to add this one... but I am checking with the code if it will have a conflict or not following the way @daneden write animations. |
I like it! ❤️ We actually don't want to add the |
Cool @daneden ! @jamesgeorge007 , I'll happily merge this when you remove the |
@eltonmesquita Sure, Thank you. |
@eltonmesquita @daneden Removed |
@jamesgeorge007 alright well done... @eltonmesquita please merge this one... |
animate-config.json
Outdated
@@ -9,7 +9,8 @@ | |||
"swing": true, | |||
"tada": true, | |||
"wobble": true, | |||
"jello": true | |||
"jello": true, | |||
"hearBeat": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually need to fix this typo first!
@daneden Typos fixed! 👍 |
Awesome! I actually just noticed that |
@daneden I'm not sure what lead to conflicts. I just installed the dependencies as listed within the package.json file and ran |
@jamesgeorge007 your branch has just become outdated because of some merges that happened before. Just build and commit it and everything will be ok. |
This is adding |
This is in reference to the issue #829 which deals about adding a Heart-Beat animation.