Fast forward on long press #486
Conversation
…press # Conflicts: # core/ui/src/main/res/values/strings.xml
|
@Yashraj254 Could you use Coroutine instead of handler |
|
And the gesture also works with two fingers. Make it only activate with one finger |
Yashraj254
force-pushed
the
fast_forward_on_long_press
branch
from
a7432d5 to
193c9d4
Compare
|
@anilbeesetti i am not able to make it work for the case, when user is holding the screen with two fingers and if he lift up one of his finger while holding the screen with the other one , it won't work unless he releases his other finger as well and tap and hold the screen again... |
...player/src/main/java/dev/anilbeesetti/nextplayer/feature/player/utils/PlayerGestureHelper.kt
Outdated
Show resolved
Hide resolved
|
@anilbeesetti i have made some changes to it, it works now. |
|
@Yashraj254 Unfortunately, i am putting this pr on hold until the issue #459 is fixed since this pr also adds the slider dialog. some users are reporting crash on changing the slider value. I need to look into the crash issue first. Btw does slider crash issue happen on your side too or everything good |
|
@anilbeesetti No, no crashes, not even for once |
|
@anilbeesetti how about using Firebase Crashlytics in this app... |
|
No way, i'm against that proprietary crap |
@anilbeesetti ok no problem, btw is there any specific reason behind why not to use it.. i haven't personally used it before, all i know it helps in tracking app crashes.. |
|
Because, it's not open source and it's google product. And doesn't align with foss principles |
|
Ok, got it. |
|
Firebase Crashlytics has foss alternatives see z-huang/InnerTune#935 (comment) |
|
The reason for not merging this seems now resolved (for those affected in the first place) and the issue ticket is closed, so maybe you can merge this PR, I like this feature in XPlayer and it will be nice if this awesome player has it to. @anilbeesetti Please read your E-Mails, there should be at least ~2 to 4 with some suggestions... |
|
@drogga do suggestions, issues in github only. And this will be merged as soon as possible |
|
It won't harm\hurt if you read them (3 E-Mails total) anyway, just to get a general idea of what they are about, but OK, no worries, I will post them here in the discussions tab, because I don't like creating issue tickets in GitHub, but prefer E-Mails (I have my reasons and not having PMs\DMs here doesn't help). Thanks once again, looking forward to the version with this implemented ;) |
…press # Conflicts: # core/model/src/main/java/dev/anilbeesetti/nextplayer/core/model/PlayerPreferences.kt # core/ui/src/main/res/values/strings.xml # feature/player/src/main/java/dev/anilbeesetti/nextplayer/feature/player/utils/PlayerGestureHelper.kt # feature/settings/src/main/java/dev/anilbeesetti/nextplayer/settings/screens/player/PlayerPreferencesScreen.kt
|
@anilbeesetti hey, i think it can be merged now,or do you still see any app crashes or any other issues.. |
|
my bad, i forgot to test it when the video is already playing at a different speed other than the default(1.0f) speed.. |
|
@Yashraj254 Thank you for implementing this feature |
|
@anilbeesetti thanks to you too as you worked more than me on this feature and i got to learn more about covering the edge cases.. |
sample5.mp4