chore(tests): e2e tests #142
Merged
+167
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
force-pushed
the
e2e_tests
branch
2 times, most recently
from
e1fcb4f to
0537a9e
Compare
|
tavis failing 🙁 |
sjelin
force-pushed
the
e2e_tests
branch
7 times, most recently
from
33edb73 to
c94a522
Compare
sjelin
force-pushed
the
e2e_tests
branch
10 times, most recently
from
f2526b1 to
c06d9f3
Compare
sjelin
force-pushed
the
e2e_tests
branch
4 times, most recently
from
7aaa7bb to
8fa2626
Compare
sjelin
force-pushed
the
e2e_tests
branch
8 times, most recently
from
3e1c691 to
73c27e8
Compare
|
I only ended up being able to support a subset of tests on travis, but this should be good to go once we merge in #162 |
|
Unblocked! This is ready to review, but we should still merge #161 first though |
heathkit
reviewed
Nov 28, 2016
| }); | ||
| gulp.task('start', ['build', 'shutdown'], function(done) { |
There was a problem hiding this comment.
fyi, Craig and I have talked about moving away from gulp to just shell scripts. That's similar to what Angular does for their CI. I think it's a bit easier to maintain, when all you're doing is spawning a bunch of processes in sequence.
There was a problem hiding this comment.
I'll leave the transition to Craig. But I do agree.
heathkit
reviewed
Nov 28, 2016
|
|
||
| gulp.task('test', ['format', 'test:unit', 'test:e2e']); | ||
| gulp.task('test:no_update', ['format', 'test:unit', 'test:e2e:no_update']); | ||
| gulp.task('test:no_screen', ['format', 'test:unit', 'test:e2e:no_screen']); |
There was a problem hiding this comment.
I think 'headless' is the more common term for this kind of thing than 'no_screen', but it's up to you.
|
lgtm! Just some optional suggestions |
Travis only runs a subset of tests via `npm run test_travis`, but `npm test` runs a full suite. See angular#165 for details on why travis cannot run all tests.
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 16, 2016
Travis only runs a subset of tests via `npm run test_travis`, but `npm test` runs a full suite. See angular#165 for details on why travis cannot run all tests.
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
Travis only runs a subset of tests via `npm run test_travis`, but `npm test` runs a full suite. See angular#165 for details on why travis cannot run all tests.
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
Travis only runs a subset of tests via `npm run test_travis`, but `npm test` runs a full suite. See angular#165 for details on why travis cannot run all tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis only runs a subset of tests via
npm run test_travis, butnpm testruns a full suite.See #165 for details on why travis cannot run all tests.