This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): default dropdown to position bottom as default #11670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
position="top"
instead ofbottom
.Issue Number:
Fixes #11656. Relates to #10859, #11629, #11575.
What is the new behavior?
top
orbottom
position.$mdUtil.getViewportTop
to handle when body scrolling is disabledDoes this PR introduce a breaking change?
Other information
You can test the original CodePen from #10859 with the changes from this PR plus some helpful console logging in this CodePen to get a better understanding of the updated algorithm.
@marosoft if you have some time, please take a look at this to check the functionality. Please ask questions about the code changes if you have any as well 😄