Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): default dropdown to position bottom as default #11670

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Mar 10, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
Fixes #11656. Relates to #10859, #11629, #11575.

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

You can test the original CodePen from #10859 with the changes from this PR plus some helpful console logging in this CodePen to get a better understanding of the updated algorithm.

@marosoft if you have some time, please take a look at this to check the functionality. Please ask questions about the code changes if you have any as well 😄

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Mar 10, 2019
@Splaktar Splaktar added this to the 1.1.14 milestone Mar 10, 2019
@Splaktar Splaktar self-assigned this Mar 10, 2019
@Splaktar Splaktar added type: bug severity: regression This issue is related to a regression P3: important Important issues that really should be fixed when possible. labels Mar 10, 2019
@Splaktar Splaktar force-pushed the autocomplete-defaultPositionBottom branch from ea3b8c1 to cab0dcf Compare March 10, 2019 09:22
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Mar 10, 2019
@Splaktar Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs and removed pr: merge ready This PR is ready for a caretaker to review labels Mar 10, 2019
@Splaktar
Copy link
Member Author

PR #11664 includes some similar (but different) changes related to part of this PR. It also includes some more unit tests. I need to take a look at it to see if I should modify the approach of this PR slightly.

@veneliniliev
Copy link

please merge this!

@Splaktar Splaktar modified the milestones: 1.1.14, 1.1.15 Mar 18, 2019
fix horizontal alignment edge cases
fix $mdUtil.getViewportTop to handle when body scrolling is disabled

Fixes #11656. Relates to #10859, #11629, #11575.
@Splaktar Splaktar force-pushed the autocomplete-defaultPositionBottom branch from cab0dcf to e41ef82 Compare March 18, 2019 23:09
@Splaktar
Copy link
Member Author

I looked at the test added in PR #11664, but unfortunately it passes without these changes (and without the changes in that PR) so it doesn't appear to provide any value to this PR.

I've rebased this PR and it should be ready for presubmit.

@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Mar 18, 2019
@andrewseguin andrewseguin merged commit 7674959 into master Mar 20, 2019
@Splaktar Splaktar deleted the autocomplete-defaultPositionBottom branch March 21, 2019 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autocomplete: dropdown opens to the top after upgrade to 1.1.13
4 participants