Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(panel): caching of panels by id is not working #11638

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Feb 15, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

trackedPanels caching works for tooltips but not panels. See more.

Issue Number:
Fixes #10894

What is the new behavior?

trackedPanels caching works for tooltips and panels.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

it worked for tooltips but not panels

Fixes #10894
@Splaktar Splaktar added this to the 1.1.14 milestone Feb 15, 2019
@Splaktar Splaktar self-assigned this Feb 15, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Feb 15, 2019
@Splaktar Splaktar added type: bug P3: important Important issues that really should be fixed when possible. labels Feb 15, 2019
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Feb 15, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the pr: lgtm This PR has been approved by the reviewer label Feb 15, 2019
@Splaktar Splaktar assigned andrewseguin and unassigned jelbourn Feb 26, 2019
@josephperrott josephperrott merged commit 649116b into master Mar 6, 2019
@Splaktar Splaktar deleted the panel-trackedPanelsCaching branch March 7, 2019 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panel: trackedPanels caching issue
5 participants