Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

menu(dense): add demo and docs. fix min-height when scrollable #11602

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When using md-dense class with md-menu-content and there are enough options to cause scrolling, the items are overlapping and jammed together.

Issue Number:
Fixes #11278. Closes #11279.

What is the new behavior?

When using md-dense class with md-menu-content and there are enough options to cause scrolling, the items are properly spaced vertically with a min-height of 32px instead of 0.

There are new docs and a demo of using md-dense with md-menu.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added this to the 1.1.13 milestone Jan 22, 2019
@Splaktar Splaktar self-assigned this Jan 22, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 22, 2019
@Splaktar Splaktar added type: bug type: docs P3: important Important issues that really should be fixed when possible. CSS: High Density labels Jan 22, 2019
@Splaktar Splaktar added ui: CSS pr: merge ready This PR is ready for a caretaker to review labels Jan 22, 2019
@Splaktar Splaktar assigned jelbourn and unassigned mmalerba Feb 5, 2019
@jelbourn jelbourn merged commit d370eb2 into master Feb 8, 2019
@Splaktar Splaktar deleted the menu-scrollableDenseOptions branch February 8, 2019 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ CSS: High Density P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: bug type: docs ui: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu: dense styling issue when scrollable
5 participants