Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

docs(util): fix incorrect Closure types and JSDoc #11590

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jan 9, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[x] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Missing Closure types, incorrect JSDoc variable names, etc.

Issue Number:
N/A

What is the new behavior?

Properly formatted JSDoc with correct variable names and Closure types.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar Splaktar added type: docs pr: merge ready This PR is ready for a caretaker to review P5: nice to have These issues will not be fixed without community contributions. labels Jan 9, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Jan 9, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 9, 2019
@Splaktar Splaktar assigned mmalerba and unassigned andrewseguin Jan 29, 2019
@Splaktar Splaktar assigned jelbourn and unassigned mmalerba Feb 5, 2019
@jelbourn jelbourn merged commit ff53136 into master Feb 8, 2019
@Splaktar Splaktar deleted the util-fix-jsdoc branch February 8, 2019 23:30
@josephperrott josephperrott self-assigned this Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P5: nice to have These issues will not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants