Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

docs(changelog,build,commit-levels,readme): updates for v1.1.6 #11076

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jan 18, 2018

add contributors to changelog
refine release process in readme
add npm script for building contributor list for a release
for example use npm run contributors:release -- 2017-09-07 for v1.1.6
fix broken headers in Build docs
fix theming guide link in Build docs
update Commit Levels doc to the current state of the project
fix note in contributors page to match actual sorting

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The documentation is inaccurate and out of date.

Issue Number:
N/A

What is the new behavior?

The documentation is updated to the current state of the project.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

@Splaktar Splaktar added type: docs pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Jan 18, 2018
@Splaktar Splaktar added this to the 1.1.7 milestone Jan 18, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 18, 2018
@Splaktar Splaktar added the P2: required Issues that must be fixed. label Jan 18, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awaiting approval from @jelbourn before merge.

* Michael Prentice is the primary PR reviewer
* Should confirm Karma tests pass
* Google Caretakers:
* Includes: [Jeremy Elbourn](https://github.com/jelbourn), [Andrew Seguin](https://github.com/andrewseguin), [Joey Perrott](https://github.com/josephperrott), [Tina Yuangao](https://github.com/tinayuangao)
Copy link
Member

@josephperrott josephperrott Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miles should also be included here:

[Miles Malerba](https://github.com/mmalerba)


https://material.angularjs.org/#/Theming/01_introduction
[G the Theming Guide](https://material.angularjs.org/latest/Theming/01_introduction)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that typo

@Splaktar
Copy link
Member Author

Splaktar commented Jan 18, 2018

Typo fixed. Miles added. Updated github-contributors-list to latest version w/ infinite recursion fix.

It should be good to go now.

add contributors to changelog
refine release process in readme
add npm script for building contributor list for a release
for example use `npm run contributors:release -- 2017-09-07` for v1.1.6
fix broken headers in Build docs
fix theming guide link in Build docs
update Commit Levels doc to the current state of the project
fix note in contributors page to match actual sorting
update to new github-contributors-list to get infinite recursion fix
@josephperrott josephperrott merged commit ef537d5 into angular:master Jan 18, 2018
@Splaktar Splaktar deleted the contributorsUpdate branch January 27, 2018 07:16
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants