Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

docs(getting-started): fix anchor in installing AngularJS Material link #11074

Merged
merged 1 commit into from
Jan 17, 2018
Merged

docs(getting-started): fix anchor in installing AngularJS Material link #11074

merged 1 commit into from
Jan 17, 2018

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The anchor in the link doesn't work as it was renamed from angular to angularjs.

Issue Number:
N/A

What is the new behavior?

The link goes to bower-material and then scrolls down to the section of the readme for installing AngularJS Material.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 17, 2018
@Splaktar Splaktar added type: docs P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Jan 17, 2018
@Splaktar Splaktar added this to the 1.1.7 milestone Jan 17, 2018
josephperrott
josephperrott approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the pr: lgtm This PR has been approved by the reviewer label Jan 17, 2018
@josephperrott josephperrott merged commit cc73422 into angular:master Jan 17, 2018
@Splaktar Splaktar deleted the fixBowerMaterialLink branch January 18, 2018 08:26
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
@Splaktar @chmelevskij
docs(getting-started): fix anchor in installing AngularJS Material li…
12f6e74 
…nk (angular#11074)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@andrewseguin andrewseguin

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Milestone
1.1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @josephperrott @googlebot @andrewseguin