Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

style(branding): branding consistency fixup #10307

Merged
merged 1 commit into from
Mar 7, 2017
Merged

style(branding): branding consistency fixup #10307

merged 1 commit into from
Mar 7, 2017

Conversation

EladBezalel
Copy link
Member

fixes #10304

@EladBezalel EladBezalel requested a review from jelbourn January 25, 2017 22:14
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 25, 2017
jelbourn
jelbourn reviewed Jan 25, 2017
View reviewed changes
README.md Outdated
@@ -44,7 +44,7 @@ Based on the number of unique contributors and repository forks, GitHub Octovers

Angular Material has revised/improved its build processes. To preserve stability with applications currently using Angular Material, we will have three (3) types of releases:

* `major` : this type of release will be the Angular 2.x efforts maintained in a separate repository called [Material2](https://github.com/angular/material2). This type of release will not be used within Angular Material 1.x.
* `major` : this type of release will be the Angular efforts maintained in a separate repository called [Angular Material](https://github.com/angular/material2). This type of release will not be used within AngularJS Material.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Called Angular Material" is a bit odd here since the repo itself is still called material2. How about "Major releases will be done as part of the latest iteration of Angular Material on a [separate repo]".

jelbourn
jelbourn approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Still LGTM

@jelbourn
Copy link
Member

jelbourn commented Jan 27, 2017 •
edited
Loading

@EladBezalel missed one spot in home.tmpl.html that refers to "Angular 2".

We should also update this paragraph:

  For developers using AngularJS, Angular Material is both a UI Component framework and a reference implementation of Google's
  Material Design Specification. This project provides a set of reusable, well-tested, and
  accessible UI components based on Material Design.

To just say "AngularJS Material" at the beginning

(and anywhere else in the file)

@EladBezalel
Copy link
Member Author

That's so weird ! I found a lot more that i couldn't beforehand, PR with fixes soon..

@ThomasBurleson ThomasBurleson added this to the 1.1.4 milestone Mar 7, 2017
@ThomasBurleson ThomasBurleson added P0: critical Critical issues that must be addressed immediately. needs: presubmit labels Mar 7, 2017
@tinayuangao tinayuangao merged commit e06284a into master Mar 7, 2017
@EladBezalel EladBezalel deleted the branding branch March 8, 2017 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P0: critical Critical issues that must be addressed immediately.
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.

Branding consistency fixup
5 participants
@EladBezalel @jelbourn @ThomasBurleson @googlebot @tinayuangao