This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(panel): Configuration ID for tracking #9356
Labels
Milestone
Comments
bradrich
added a commit
to bradrich/material
that referenced
this issue
Aug 22, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated. Fixes angular#9356 Also, several syntax issues throughout the documentation/commenting have been corrected. Fixes angular#9357 Ping ErinCoughlan
bradrich
added a commit
to bradrich/material
that referenced
this issue
Aug 22, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated. Fixes angular#9356 Also, several syntax issues throughout the documentation/commenting have been corrected. Fixes angular#9357 Ping ErinCoughlan
bradrich
added a commit
to bradrich/material
that referenced
this issue
Aug 23, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated. Fixes angular#9356 Also, several syntax issues throughout the documentation/commenting have been corrected. Fixes angular#9357 Ping ErinCoughlan
bradrich
added a commit
to bradrich/material
that referenced
this issue
Aug 23, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated. Fixes angular#9356 Also, several syntax issues throughout the documentation/commenting have been corrected. Fixes angular#9357 Ping ErinCoughlan
bradrich
added a commit
to bradrich/material
that referenced
this issue
Aug 24, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated. Fixes angular#9356 Also, several syntax issues throughout the documentation/commenting have been corrected. Fixes angular#9357 Ping ErinCoughlan
jelbourn
pushed a commit
that referenced
this issue
Aug 24, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated. Fixes #9356 Also, several syntax issues throughout the documentation/commenting have been corrected. Fixes #9357 Ping ErinCoughlan
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Actual Behavior:
What is the issue? *
Currently, the mdPanel service assigns an ID, that is a simple string, to any panel that it creates. However, the service does nothing to track the panels with this ID. It is possible to open multiple panels by clicking on the same button over and over.What is the expected behavior?
The user should be able to provide an ID within the panel configuration. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID should be ignored.CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:
N/ADetails:
N/AAngular Versions: *
Angular Version:
LatestAngular Material Version:
LatestAdditional Information:
Browser Type: *
N/ABrowser Version: *
N/AOS: *
N/AStack Traces:
N/APing @ErinCoughlan
The text was updated successfully, but these errors were encountered: