Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(panel): Configuration ID for tracking #9356

Closed
bradrich opened this issue Aug 19, 2016 · 0 comments
Closed

feat(panel): Configuration ID for tracking #9356

bradrich opened this issue Aug 19, 2016 · 0 comments
Assignees
Labels
has: Pull Request A PR has been created to address this issue type: enhancement type: feature
Milestone

Comments

@bradrich
Copy link
Contributor

bradrich commented Aug 19, 2016

Actual Behavior:

  • What is the issue? * Currently, the mdPanel service assigns an ID, that is a simple string, to any panel that it creates. However, the service does nothing to track the panels with this ID. It is possible to open multiple panels by clicking on the same button over and over.
  • What is the expected behavior? The user should be able to provide an ID within the panel configuration. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID should be ignored.

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue: N/A
  • Details: N/A

Angular Versions: *

  • Angular Version: Latest
  • Angular Material Version: Latest

Additional Information:

  • Browser Type: * N/A
  • Browser Version: * N/A
  • OS: * N/A
  • Stack Traces: N/A

Ping @ErinCoughlan

@bradrich bradrich self-assigned this Aug 19, 2016
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.1 Aug 22, 2016
bradrich added a commit to bradrich/material that referenced this issue Aug 22, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated.

Fixes angular#9356

Also, several syntax issues throughout the documentation/commenting have been corrected.

Fixes angular#9357

Ping ErinCoughlan
@bradrich bradrich added the has: Pull Request A PR has been created to address this issue label Aug 22, 2016
bradrich added a commit to bradrich/material that referenced this issue Aug 22, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated.

Fixes angular#9356

Also, several syntax issues throughout the documentation/commenting have been corrected.

Fixes angular#9357

Ping ErinCoughlan
bradrich added a commit to bradrich/material that referenced this issue Aug 23, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated.

Fixes angular#9356

Also, several syntax issues throughout the documentation/commenting have been corrected.

Fixes angular#9357

Ping ErinCoughlan
bradrich added a commit to bradrich/material that referenced this issue Aug 23, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated.

Fixes angular#9356

Also, several syntax issues throughout the documentation/commenting have been corrected.

Fixes angular#9357

Ping ErinCoughlan
bradrich added a commit to bradrich/material that referenced this issue Aug 24, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated.

Fixes angular#9356

Also, several syntax issues throughout the documentation/commenting have been corrected.

Fixes angular#9357

Ping ErinCoughlan
jelbourn pushed a commit that referenced this issue Aug 24, 2016
The user is now able to provide an ID as a property of the panel configuration object. When an ID is provided, the created panel is added to a tracked panels object. Any subsequent requests made to create a panel with that ID are ignored. This is useful in having the panel service not open multiple panels from the same user interaction when there is no backdrop and events are propagated.

Fixes #9356

Also, several syntax issues throughout the documentation/commenting have been corrected.

Fixes #9357

Ping ErinCoughlan
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue type: enhancement type: feature
Projects
None yet
Development

No branches or pull requests

2 participants