Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-dev): use x-access-token as username for git url #756

Closed

Conversation

josephperrott
Copy link
Member

When providing authentication via URL the username should be set to x-access-token based on
documentation for Github Apps.

When providing authentication via URL the username should be set to `x-access-token` based on
documentation for Github Apps.
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2022
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests are failing and generated files need updates

@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit afa79a5.

@josephperrott josephperrott deleted the fix-access-token-username branch August 10, 2022 19:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants