fix(apps): misc fixes from testing #752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly revoke the installation token, use a static port of 8080, extend the heartbeat interval length to 10 seconds, improve request header names.
devversion
approved these changes
Aug 3, 2022
|
This PR was merged into the repository by commit 8fa6149. |
devversion
reviewed
Aug 3, 2022
| * | ||
| * 10 seconds is used as during the local PR validation process, the javascript thread | ||
| * becomes blocked, and can cause a timeout. | ||
| */ |
There was a problem hiding this comment.
Ohh, that is pretty interesting. Couldn't we offload the heartbeat somehow? It seems pretty brittle that we need a large enough timeout here (especially if we add stuff in the future / use it for other tools).
There was a problem hiding this comment.
Yeah, I think it makes sense in a follow up to do once we have everything in place as part of larger testing.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly revoke the installation token, use a static port of 8080, extend the heartbeat interval
length to 10 seconds, improve request header names.