Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create --dry-run for pr merge #733

Closed

Conversation

josephperrott
Copy link
Member

See individual commits.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jul 22, 2022
@josephperrott josephperrott requested a review from devversion July 22, 2022 17:10
@josephperrott josephperrott force-pushed the check-mergable-before-prompt branch 2 times, most recently from a85d468 to 977c904 Compare July 23, 2022 18:48
@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 23, 2022
@josephperrott josephperrott force-pushed the check-mergable-before-prompt branch 2 times, most recently from 87a403a to 778bbac Compare July 23, 2022 19:57
josephperrott and others added 4 commits July 26, 2022 11:52
…n pr merge tooling

Rather than prompting for confirmation before checking for merge conflicts, allowing
for the tool to potentially fail before the merge occurs but after the user has confirmed
the action via prompt.  The conflicts should be detected so that when prompting for final
confirmation, the user can be assured the actual merge will occur as expected.
Add a --dry-run flag to allow for checking if a PR is currently mergable into its target branches
in the current state.
@devversion devversion force-pushed the check-mergable-before-prompt branch from 5f43df3 to 32d3e6c Compare July 26, 2022 12:52
@devversion
Copy link
Member

This PR was merged into the repository by commit 418ef13.

devversion pushed a commit that referenced this pull request Jul 26, 2022
Add a --dry-run flag to allow for checking if a PR is currently mergable into its target branches
in the current state.

PR Close #733
devversion added a commit that referenced this pull request Jul 26, 2022
@devversion
Copy link
Member

FYI: I just improved the logging a little bit, and also avoided the second git fetch. This was just some clean-up so I went ahead and merged the PR since it looked great aside from the second git fetch.

@josephperrott josephperrott deleted the check-mergable-before-prompt branch August 10, 2022 19:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants