fix(ng-dev): force prompt should only ignore the failed validation #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This also enables us to skip the "changes allow for target label" validation, fixing issues like we had last time. |
devversion
force-pushed
the
misc-fixes-merge-tool
branch
2 times, most recently
from
1b5e9b3 to
3be2001
Compare
Currently when a validation check fails, the caretaker is prompted to continue forcibly if the failure was non-fatal. This seemed nice at first glance, but there is a real issue here. The force merge run might hide actual validations which might have not been hit before. To fix this, we introduce an incremental validation system where we run validations from a config (all by default) and upon failure, if non-fatal the individual validation can be ignored, re-attempting the merge. Also as part of this the validation logic has been refactored/reworked to individual files with some more complicated wrapper logic that ensures we properly skip and report validation failures in a safe way.
devversion
force-pushed
the
misc-fixes-merge-tool
branch
from
3be2001 to
c6654e4
Compare
…tion Do not query active release trains if target labeling is disabled
devversion
force-pushed
the
misc-fixes-merge-tool
branch
from
9aa5366 to
af4b7ad
Compare
…tion Cleanup remaining special flag references and remove unnecessary config read
…tion Improve error messaging styling
…tion Improve error messaging styling
|
This PR was merged into the repository by commit 0f1cace. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a validation check fails, the caretaker is prompted to
continue forcibly if the failure was non-fatal.
This seemed nice at first glance, but there is a real issue here. The
force merge run might hide actual validations which might have not been
hit before.
To fix this, we introduce an incremental validation system where we run
validations from a config (all by default) and upon failure, if
non-fatal the individual validation can be ignored, re-attempting the
merge.
Also as part of this the validation logic has been refactored/reworked
to individual files with some more complicated wrapper logic that
ensures we properly skip and report validation failures in a safe way.