Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ng-dev): abbreviated SHA stamp #373

Closed
wants to merge 1 commit into from
Closed

feat(ng-dev): abbreviated SHA stamp #373

wants to merge 1 commit into from

Conversation

kormide
Copy link
Contributor

@kormide kormide commented Jan 31, 2022

@josephperrott @devversion
fyi: @gregmagolan

Test output:

BUILD_SCM_BRANCH snapshot-test
BUILD_SCM_COMMIT_SHA bb8bc80581417898b10bdc23ef4d9ee4295da2a9
BUILD_SCM_HASH bb8bc80581417898b10bdc23ef4d9ee4295da2a9
BUILD_SCM_HASH_ABBREV bb8bc8058
BUILD_SCM_BRANCH snapshot-test
BUILD_SCM_LOCAL_CHANGES false
BUILD_SCM_USER Derek Cormier <[email protected]>
BUILD_SCM_VERSION 14.0.0-next.0
BUILD_SCM_EXPERIMENTAL_VERSION 0.1400.0-next.0

Needed for cli snapshot build tagging.

josephperrott
josephperrott approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2022
devversion
devversion approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think generally relying on this should be avoided as abbreviated SHAs can become invalid. Seems fine for snapshot builds though.

@josephperrott
Copy link
Member

@kormide Looks like it needs a rebase real quick

@kormide
Copy link
Contributor Author

kormide commented Jan 31, 2022

Rebased

@josephperrott
Copy link
Member

This PR was merged into the repository by commit c922f5b.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kormide @josephperrott @devversion