Skip to content

Commit

Permalink
fix(github-actions): use proper variable names when accessing deploy …
Browse files Browse the repository at this point in the history
…metadata

The wrong variables were used and the GitHub action did not even fail,
but instead use some undefined value, causing the Firebase URLs to
include some non-deterministic string.

Also the comment did not get posted because the PR number was not a
valid one. Even here, the action did not print a failure..
  • Loading branch information
devversion committed Nov 30, 2022
1 parent 923d69d commit f2bde1b
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ runs:
expires: 20d
projectId: '${{inputs.firebase-project-id}}'
entryPoint: '${{inputs.firebase-config-dir}}'
channelId: pr-${{steps.artifact-info.outputs.pull-number}}-${{steps.artifact-info.outputs.build-revision}}
channelId: pr-${{steps.artifact-info.outputs.unsafe-pull-number}}-${{steps.artifact-info.outputs.unsafe-build-revision}}

- uses: marocchino/sticky-pull-request-comment@f3bbb8300013c686241004a1c1b5d4045b10bc30 # tag=v2.0.0
with:
message: |
Deployed ${{inputs.workflow-artifact-name}} to: ${{steps.deploy.outputs.details_url}}
number: ${{steps.artifact-info.outputs.pull-number}}
number: ${{steps.artifact-info.outputs.unsafe-pull-number}}

0 comments on commit f2bde1b

Please sign in to comment.