-
Notifications
You must be signed in to change notification settings - Fork 54
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(bazel): no browsers matching for windows x86_64 cpu (#220)
With the recent refactorings for supporting M1 browsers, we added our own constraints/config settings. An incorrect assumption was made that the x64 CPU constraint would also match the x32 constraint given that Windows x64 can always run x32 programs. This seems to be not the case (and makes sense in retrospective). This commit fixes the browser configurations by always using x64 instead. The x32 constraint is removed because `rules_webtesting` and other parts of the tooling seem to use x64 windows only, and at this point supporting 32 bit windows seems not wort maintaining/ the additional maintenance. PR Close #220
- Loading branch information
1 parent
7bdd465
commit 703aefc
Showing
3 changed files
with
1 addition
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters