Skip to content

Commit

Permalink
fixup! feat(ng-dev/release): add marker between generated changelog e…
Browse files Browse the repository at this point in the history
…ntries
  • Loading branch information
josephperrott committed Sep 13, 2021
1 parent e0233a6 commit 0065b53
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions ng-dev/release/notes/changelog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ export class Changelog {
*/
private get archiveEntries() {
if (this._archiveEntries === undefined) {
return this._archiveEntries = this.getEntriesFor(this.archiveFilePath);
return (this._archiveEntries = this.getEntriesFor(this.archiveFilePath));
}
return this._archiveEntries;
}
private _archiveEntries: undefined | ChangelogEntry[] = undefined
private _archiveEntries: undefined | ChangelogEntry[] = undefined;
/** Whether the changelog archive has entries upon intialization. */
private alreadyHasChangelogArchive = this.archiveEntries.length !== 0;

Expand All @@ -69,6 +69,11 @@ export class Changelog {
/**
* Move all changelog entries from the CHANGELOG.md file for versions prior to the provided
* version to the changelog archive.
*
* Versions should be used to determine which entries are moved to archive as versions are the
* most accurate piece of context found within a changelog entry to determine its relationship to
* other changelog entries. This allows for example, moving all changelog entries out of the
* main changelog when a version moves out of support.
*/
moveEntriesPriorToVersionToArchive(version: semver.SemVer) {
[...this.entries].reverse().forEach((entry: ChangelogEntry) => {
Expand Down

0 comments on commit 0065b53

Please sign in to comment.