Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button-toggle): allow toggle group elevation to be overwritten #7909

Closed

Conversation

crisbeto
Copy link
Member

Allows for consumer to specify a custom elevation on a mat-button-toggle-group.

Relates to #7264.

@crisbeto crisbeto requested a review from tinayuangao as a code owner October 19, 2017 19:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2017
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 19, 2017
@crisbeto crisbeto force-pushed the 7264/button-toggle-elevation branch 2 times, most recently from b9c5be7 to 49fba7f Compare November 20, 2017 20:44
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@crisbeto crisbeto force-pushed the 7264/button-toggle-elevation branch from 49fba7f to b283477 Compare April 18, 2018 19:04
@crisbeto crisbeto force-pushed the 7264/button-toggle-elevation branch from b283477 to 0d8345f Compare September 26, 2018 21:38
@crisbeto crisbeto requested a review from jelbourn as a code owner September 26, 2018 21:38
@crisbeto crisbeto force-pushed the 7264/button-toggle-elevation branch from 0d8345f to 52bbcbb Compare October 1, 2018 20:40
Allows for consumer to specify a custom elevation on a `mat-button-toggle-group`.

Relates to angular#7264.
@crisbeto crisbeto force-pushed the 7264/button-toggle-elevation branch from 52bbcbb to fc5d589 Compare November 11, 2018 21:27
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 4, 2019
…yling applied incorrectly

* Fixes not being able to override the elevation of a button toggle. Similar to angular#7909, but makes avoids issues with the new appearance.
* Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing.

Fixes angular#14721.
@crisbeto
Copy link
Member Author

crisbeto commented Jan 4, 2019

Closing in favor of #14722.

@crisbeto crisbeto closed this Jan 4, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 27, 2019
…yling applied incorrectly

* Fixes not being able to override the elevation of a button toggle. Similar to angular#7909, but makes avoids issues with the new appearance.
* Fixes some of the styles that are only intended to be applied in high contrast mode being active all the time. Seems like an issue while rebasing.

Fixes angular#14721.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants