-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: show inherited members in dgeni #3599
Merged
mmalerba
merged 4 commits into
angular:master
from
devversion:build/dgeni-inherited-members
Mar 17, 2017
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/** | ||
* Processor that iterates through all class docs and determines if a class inherits | ||
* another class. Inherited class-docs will be linked to the original class-doc. | ||
*/ | ||
|
||
const ts = require('typescript'); | ||
|
||
module.exports = function linkInheritedDocs(readTypeScriptModules, tsParser) { | ||
|
||
let checker = null; | ||
|
||
return { | ||
$runAfter: ['readTypeScriptModules'], | ||
$runBefore: ['categorizer'], | ||
$process: processDocs, | ||
}; | ||
|
||
function processDocs(docs) { | ||
// Use the configuration from the `readTypeScriptModules` processor. | ||
let {sourceFiles, basePath} = readTypeScriptModules; | ||
|
||
// To be able to map the TypeScript Nodes to the according symbols we need to use the same | ||
// TypeScript configuration as in the `readTypeScriptModules` processor. | ||
checker = tsParser.parse(sourceFiles, basePath).typeChecker; | ||
|
||
// Iterate through all class docs and resolve the inherited docs. | ||
docs.filter(doc => doc.docType === 'class').forEach(classDoc => { | ||
resolveInheritedDoc(classDoc, docs); | ||
}); | ||
} | ||
|
||
function resolveInheritedDoc(classDoc, docs) { | ||
let inheritedType = resolveInheritedType(classDoc.exportSymbol); | ||
let inheritedSymbol = inheritedType && inheritedType.symbol; | ||
|
||
if (inheritedSymbol) { | ||
classDoc.inheritedSymbol = inheritedSymbol; | ||
classDoc.inheritedDoc = docs.find(doc => doc.exportSymbol === inheritedSymbol); | ||
} | ||
} | ||
|
||
function resolveInheritedType(classSymbol) { | ||
// Ensure that the symbol can be converted into a TypeScript ClassDeclaration. | ||
if (classSymbol.flags & ~ts.SymbolFlags.Class) { | ||
return; | ||
} | ||
|
||
let declaration = classSymbol.valueDeclaration || classSymbol.declarations[0]; | ||
let typeExpression = ts.getClassExtendsHeritageClauseElement(declaration); | ||
|
||
return typeExpression ? checker.getTypeAtLocation(typeExpression) : null; | ||
} | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a top level file comment that explains what this does.