build: update to TypeScript 5.2 and Angular 17 #27792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
angular-robot
bot
added
the
area: build & ci
crisbeto
force-pushed
the
ts-5.2
branch
5 times, most recently
from
f7b6614 to
4c92e51
Compare
Updates the repo to TS 5.2 and Angular 17.
crisbeto
requested review from
devversion,
josephperrott,
andrewseguin and
jelbourn
as code owners
devversion
approved these changes
Sep 14, 2023
| return pathToFileURL(path.join(runfiles.resolveWorkspaceRelative('./node_modules'), url)); | ||
| return pathToFileURL( | ||
| path.join(runfiles.resolveWorkspaceRelative('./node_modules'), url), | ||
| ) as URL; |
There was a problem hiding this comment.
That seems surprising, pathToFileURL should return an URL IIRC
There was a problem hiding this comment.
It returns its own URL type that used to overlap with the built-in one, but it doesn't anymore.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 2, 2023
In angular#27792 the schematics were updated to use the new default `application` builder instead of the `browser` builder. According to the CLI team we'll have to support both so these changes update our existing logic to account for both cases.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 2, 2023
In angular#27792 the schematics were updated to use the new default `application` builder instead of the `browser` builder. According to the CLI team we'll have to support both so these changes update our existing logic to account for both cases.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the repo to TS 5.2 and Angular 17.