feat(material/core): use strong focus indicators in high contrast mode #25039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
focus-indicators
branch
from
9aed5dc to
08d0c35
Compare
crisbeto
added
the
merge: preserve commits
crisbeto
force-pushed
the
focus-indicators
branch
5 times, most recently
from
76e2265 to
ee9968f
Compare
Reuses the strong focus indicators styling for high-contrast mode users.
crisbeto
force-pushed
the
focus-indicators
branch
from
ee9968f to
39036a4
Compare
crisbeto
requested review from
devversion,
mmalerba,
andrewseguin,
jelbourn and
zarend
as code owners
crisbeto
added
P2
zarend
approved these changes
Jun 10, 2022
devversion
approved these changes
Jun 10, 2022
| @@ -1,4 +1,3 @@ | |||
| @use '@angular/cdk'; | |||
There was a problem hiding this comment.
Nit: could potentially update the BUILD files to keep the build graph minimal but at the same time we don't enforce strict deps here and also don't control it nicely, so not feeling strongly..
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 15, 2022
I skipped over some of the feedback on angular#25039 in order to get the focus indicator changes merged in quicker. This is a follow-up to address the remaining feedback.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 15, 2022
I skipped over some of the feedback on angular#25039 in order to get the focus indicator changes merged in quicker. This is a follow-up to address the remaining feedback.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 15, 2022
I skipped over some of the feedback on angular#25039 in order to get the focus indicator changes merged in quicker. This is a follow-up to address the remaining feedback.
crisbeto
added a commit
that referenced
this pull request
Jun 15, 2022
I skipped over some of the feedback on #25039 in order to get the focus indicator changes merged in quicker. This is a follow-up to address the remaining feedback.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses the strong focus indicators styling for high-contrast mode users.