Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/a11y): ensure that aria describer ID is unique #24982

Merged
merged 1 commit into from
May 30, 2022
Merged

fix(cdk/a11y): ensure that aria describer ID is unique #24982

merged 1 commit into from
May 30, 2022

Conversation

crisbeto
Copy link
Member

Adds the unique application ID to the ARIA describer ID so that it's unique even if Angular is loaded multiple times.

Fixes #24917.

@crisbeto
fix(cdk/a11y): ensure that aria describer ID is unique
5cd9d08 
Adds the unique application ID to the ARIA describer ID so that it's unique even if Angular is loaded multiple times.

Fixes angular#24917.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels May 27, 2022
@crisbeto crisbeto marked this pull request as ready for review May 27, 2022 08:27
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 27, 2022
@crisbeto crisbeto self-assigned this May 30, 2022
@crisbeto crisbeto merged commit b1ed1c5 into angular:main May 30, 2022
crisbeto added a commit that referenced this pull request May 30, 2022
@crisbeto
fix(cdk/a11y): ensure that aria describer ID is unique (#24982)
4edfaed 
Adds the unique application ID to the ARIA describer ID so that it's unique even if Angular is loaded multiple times.

Fixes #24917.

(cherry picked from commit b1ed1c5)
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 7, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(CDK a11y): AriaDescriber id not unique in microfrontend / docs
2 participants
@crisbeto @devversion