Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(material/core): deprecate legacy theming API #24835

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

devversion
Copy link
Member

DEPRECATED: mat.define-dark-theme no longer accepts $primary, $accent and $warn.
Pass a single config map instead.

DEPRECATED: mat.define-light-theme no longer accepts $primary, $accent and $warn.
Pass a single config map instead.

DEPRECATED: Custom Material themes should no longer access primary, accent, warn,
is-dark, foreground and background from the theme map, but instead use the actual color
configuration (mat.get-color-config($theme)).

DEPRECATED: Passing a color configuration directly to a -theme mixin
is not supported. Pass the theme container object instead or use the dedicated
-color mixins.

DEPRECATED: `mat.define-dark-theme` no longer accepts `$primary`, `$accent` and `$warn`.
  Pass a single config map instead.

DEPRECATED: `mat.define-light-theme` no longer accepts `$primary`, `$accent` and `$warn`.
  Pass a single config map instead.

DEPRECATED: Custom Material themes should no longer access `primary`, `accent`, `warn`,
  `is-dark`, `foreground` and `background` from the theme map, but instead use the actual `color`
  configuration (`mat.get-color-config($theme)`).

DEPRECATED: Passing a color configuration directly to a `-theme` mixin
  is not supported. Pass the theme container object instead or use the dedicated
  `-color` mixins.
@devversion devversion force-pushed the deprecated-legacy-theming branch from 5cf46e4 to b0214b6 Compare April 26, 2022 13:25
@devversion devversion changed the title refactor(material/core): deprecated legacy theming API refactor(material/core): deprecate legacy theming API Apr 26, 2022
@devversion devversion requested a review from andrewseguin April 26, 2022 13:25
@devversion devversion added the target: major This PR is targeted for the next major release label Apr 26, 2022
@devversion devversion added this to the 14.0.0 milestone Apr 26, 2022
@devversion devversion marked this pull request as ready for review April 26, 2022 13:26
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Apr 26, 2022
@andrewseguin andrewseguin merged commit f30609c into angular:master Apr 26, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants