Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(material/button): fix button harness example test #24736

Merged
merged 1 commit into from
May 2, 2022
Merged

docs(material/button): fix button harness example test #24736

merged 1 commit into from
May 2, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 5, 2022

We were declaring the harness being used as a variable unecessarily. These changes align the example closer with the other harness examples.

Fixes #24732.

@crisbeto
docs(material/button): fix button harness example test
c2f255d 
We were declaring the harness being used as a variable unecessarily. These changes align the example closer with the other harness examples.

Fixes angular#24732.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe labels Apr 5, 2022
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 5, 2022 11:06
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 5, 2022
andrewseguin
andrewseguin approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd - thanks for fixing

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 2, 2022
@andrewseguin andrewseguin merged commit 2c64ae3 into angular:main May 2, 2022
andrewseguin pushed a commit that referenced this pull request May 2, 2022
@crisbeto @andrewseguin
docs(material/button): fix button harness example test (#24736)
884f760 
We were declaring the harness being used as a variable unecessarily. These changes align the example closer with the other harness examples.

Fixes #24732.

(cherry picked from commit 2c64ae3)
This was referenced May 10, 2022
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(button): button-harness-example has wrong assignment
2 participants
@crisbeto @andrewseguin