feat(cdk/portal): allow specifying injector for template portal #24554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekhmanrus
reviewed
Apr 5, 2022
Comment on lines
+184
to
+186
| const viewRef = this._viewContainerRef.createEmbeddedView(portal.templateRef, portal.context, { | ||
| injector: portal.injector, | ||
| }); |
There was a problem hiding this comment.
Should it be
const viewRef = this._viewContainerRef.createEmbeddedView(
portal.templateRef,
portal.context,
portal.injector ? { injector: portal.injector } : undefined
);instead?
See StackBlitz. When we click Render template portal button it throws an error:
There was a problem hiding this comment.
I can't reproduce this error locally in our dev app. I think the problem is that your Stackblitz is running v14 of the CDK against v13 of the Framework which doesn't support the injector option yet.
There was a problem hiding this comment.
@crisbeto, right. Sorry about that.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.