feat(material-luxon-adapter): add option to set first day of week #23948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS
google-cla
bot
added
the
cla: yes
crisbeto
added
action: merge
…lation output (#23951) Updates to Angular v13.0.1 which fixes the partial compilation output for `forwardRef` usages in queries. The fixed partial compilation output will ensure that Angular CDK/Material works with JIT linking at runtime, as done in e.g. Jest. Fix upstream: angular/angular#44113. We will add some testing for the JIT linker to the `angular/components` repository with: #23882. That should help ensuring JIT linking does not regress. Fixes #23907.
Adds support for the `auto` value of the `dir` attribute. The value gets resolved to `ltr` or `rtl` based on browser's locale. Fixes #10186.
Cleans up a bunch of workarounds and docs that were specific to ViewEngine. There are still more places to clean up, but I'm trying to make it easier to track down any potential failures.
…l components (#23912) Reworks the theming for the MDC-based components so that it doesn't emit fallback values for CSS variables. This trims ~27kb from the dev app theme. Also wraps the structural styles of the MDC-based radio button and slide toggle who have been converted to the new MDC theming API.
Adds the `composed` flag to the fake event objects so that they can propagate through a `mode: 'open'` shadow root.
…dow DOM Fixes that the children of the drag handle inside a shadow root weren't being detected. The problem was that we were using `_getEventTarget` to resolve the actual event target and using `contains` to verify that it's inside the handle. Since `contains` doesn't descend into shadow root, the call failed. These changes remove the `_getEventTarget` call since we can use the event `target` directly. Fixes #23680.
…#23759) Currently if one of the end tabs is selected and the user zooms in, we may end up showing the pagination unnecessarily. The issue comes from the fact that there's a transition on the ink bar which can cause the parent overflow while it is being measured. These changes resolve the issue by measuring a different element. Fixes #23724.
… hover (#23840) Fixes that the `:hover` styles were overriding the `:focus` and selected effects of the MDC-based `mat-list-option`.
This change is in response to feedback that it's not obvious that `TestElement.sendKeys` may behave differently in different environments. To help a tiny bit, we expand the JsDoc for `sendKeys` to mentions that it cannot reproduce native keyboard shortcuts in all environments.
Enables Angular strict template type checking for the IDE tsconfig, matching with the flag set within the Bazel compilations.
* build: update to yarn v1.22.17 Update to the latest version of yarn, 1.22.17. * build: add vendored yarn file to files ignored by prettier
Angular's QueryList first and last can actually be `undefined`, although this is not reflected by their type (this is a current bug in Angular: angular/angular#42563) this commit adds non-null assertions to first and last references within the codebase in preparation for solving the Angular bug without causing too many breaking changes For more information see: angular/angular#43604
Remove `cla: yes` from the require labels for merging as the CLACheck tool no longer relies on labels. Enforcement of the CLA being signed is still enforced by the status check which is visible both in Github as well as checked by merge tooling.
#23973) Updates the Bazel setup to the latest dev-infra and rules_nodejs version. This includes: * The removal of the spec-bundling code as that has been moved over to the shared dev-infra code. * The remoal of the AMD esbuild and devmode JS source extraction as these rules have been moved to the shared dev-infra logic. * The removal of the Angular linker ESBuild plugin creation as this logic is now exposed as shared script in the shared dev-infra package.
Now that we don't need to think about ViewEngine, we can use `ngDevMode` to tree shake the sanity check messages.
When the boundaries were added to the `drag-drop` module, I assumed that users would always want the element to be contained inside the boundary, but it looks like there are some cases where that's not the case. These changes remove the error. Fixes #23767.
…ted function usage (#23999) Fixes a couple of places where we were using the deprecated `map-get` function from Sass.
…#23994) Fixes a few cases where we weren't destroying the MDC foundation in our own components. There's also a case where we were overriding the `ngOnDestroy` from a parent component, but we weren't calling it from the override.
|
Hi @crisbeto, Thanks |
|
Can you try rebasing your PR? We were changing some of the build setup so that might be why Circle didn't pick it up. |
Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS
…nents into luxon-first-day-of-week
JiriBalcar
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
a team
as code owners
|
OK I did the rebase. |
|
It looks like the rebase got messed up since it includes 31 other commits. Can you try resubmitting the PR? Just ping me and I'll re-approve it. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add firstDayOfWeek option to be able to change first day of week behaviour through MAT_LUXON_DATE_ADAPTER_OPTIONS