fix(material/input): preserve native placeholder on non-legacy appearances #20936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
Any update on this one when this will get merged? |
crisbeto
force-pushed
the
20903/placeholder-preserve
branch
from
6ed537d to
50e7344
Compare
andrewseguin
removed
the
cla: yes
googlebot
added
the
cla: yes
|
Has CI failures |
crisbeto
force-pushed
the
20903/placeholder-preserve
branch
from
50e7344 to
6412faf
Compare
crisbeto
force-pushed
the
20903/placeholder-preserve
branch
from
6412faf to
be89dcd
Compare
…ances The `legacy` form field appearance has a feature where it promotes the input placeholder to the form field label which introduces a problem where screen readers will read out the placeholder twice. Some time ago we added logic to clear the placeholder, but it seems to be a bit too aggressive since it also clears the placeholder for other appearances. These changes scope the workaround only to the case when a placeholder would be promoted to a label. Fixes angular#20903.
crisbeto
force-pushed
the
20903/placeholder-preserve
branch
from
be89dcd to
d84c2f6
Compare
crisbeto
added
target: major
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…ances (angular#20936) The `legacy` form field appearance has a feature where it promotes the input placeholder to the form field label which introduces a problem where screen readers will read out the placeholder twice. Some time ago we added logic to clear the placeholder, but it seems to be a bit too aggressive since it also clears the placeholder for other appearances. These changes scope the workaround only to the case when a placeholder would be promoted to a label. Fixes angular#20903.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
legacyform field appearance has a feature where it promotes the input placeholder to the form field label which introduces a problem where screen readers will read out the placeholder twice. Some time ago we added logic to clear the placeholder, but it seems to be a bit too aggressive since it also clears the placeholder for other appearances.These changes scope the workaround only to the case when a placeholder would be promoted to a label.
Fixes #20903.