Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autocomplete): move harness out of experimental #17080

Merged
merged 2 commits into from
Sep 16, 2019
Merged

feat(autocomplete): move harness out of experimental #17080

merged 2 commits into from
Sep 16, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: major This PR is targeted for the next major release labels Sep 14, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Sep 14, 2019
@mmalerba mmalerba requested a review from jelbourn September 14, 2019 01:04
@mmalerba mmalerba requested review from crisbeto and a team as code owners September 14, 2019 01:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 14, 2019
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 14, 2019
@mmalerba
Copy link
Contributor Author

CARETAKER NOTE: merge-safe, but may require BUILD file updates in g3

crisbeto
crisbeto approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devversion
devversion approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. It looks like there are lint failures.

@mmalerba
Copy link
Contributor Author

comments addressed

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2019
devversion
devversion approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba mentioned this pull request Sep 16, 2019
Merged
jelbourn
jelbourn approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit dec116b into angular:master Sep 16, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mmalerba @jelbourn @crisbeto @devversion @josephperrott @googlebot