Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio): add provider for default color input #15811

Merged
merged 2 commits into from
Jun 4, 2019
Merged

feat(radio): add provider for default color input #15811

merged 2 commits into from
Jun 4, 2019

Conversation

jerome-nelson
Copy link
Contributor

fixes #12815

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 13, 2019
@jerome-nelson jerome-nelson reopened this Apr 14, 2019
@jerome-nelson
Copy link
Contributor Author

jerome-nelson commented Apr 14, 2019 •
edited
Loading

@jelbourn I'm not sure how to fix the failing checks for devapp_aot and api_golden_checks - what am I doing wrong?

Nevermind managed to get some assistance on this from @alan-agius4 - thanks

crisbeto
crisbeto reviewed Apr 14, 2019
View reviewed changes
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
jelbourn
jelbourn reviewed May 10, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a couple minor comments

@jelbourn jelbourn added the target: minor This PR is targeted for the next minor release label May 10, 2019
@andrewseguin andrewseguin added the P4 A relatively minor issue that is not relevant to core functions label May 30, 2019
jelbourn
jelbourn approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround and removed P4 A relatively minor issue that is not relevant to core functions labels May 30, 2019
@jelbourn
Copy link
Member

jelbourn commented Jun 3, 2019

Bumping the priority on this because we need it inside Google

@jerome-nelson
Copy link
Contributor Author

jerome-nelson commented Jun 4, 2019 •
edited
Loading

@jelbourn is it safe to start converting the other color inputs as well? You mentioned this in the original issue.

@josephperrott josephperrott merged commit 5c51301 into angular:master Jun 4, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@jerome-nelson @RudolfFrederiksen
feat(radio): add provider for default color input (angular#15811)
d3b4088
YourDeveloperFriend pushed a commit to YourDeveloperFriend/components that referenced this pull request Aug 16, 2019
fixup! feat(radio): add provider for default color input (angular#15811)
2c8157d
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to default color properties
7 participants
@jerome-nelson @jelbourn @crisbeto @googlebot @josephperrott @mmalerba @andrewseguin