-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form-field): remove nonbreaking space before * for required fields #15490
Conversation
I tried to add a test to check in a more deliberate way that the spaces were deliberate and there's no real DOM API I found to get the post-collapsing rendered text short of doing a screendiff test. Both innerText and textContent give the spaces pre-collapsing. I did adjust the test to match explicitly literal space and not I did not add an explicit test that puts a trailing space in the |
@stevenyxu looks like there's some failing tests |
5e76466
to
f5f25c6
Compare
The surrounding .mat-form-field-label is already white-space: nowrap so the doesn't serve any wrap-preventing function. But it does prevent any trailing <mat-label> spacing from collapsing with the space before the asterisk, causing for a bad visual appearance of a double space in these cases.
@mmalerba sorry about that. Fixed and rebased today. |
#15490) The surrounding .mat-form-field-label is already white-space: nowrap so the doesn't serve any wrap-preventing function. But it does prevent any trailing <mat-label> spacing from collapsing with the space before the asterisk, causing for a bad visual appearance of a double space in these cases.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The surrounding .mat-form-field-label is already white-space: nowrap so the doesn't serve any
wrap-preventing function. But it does prevent any trailing spacing from collapsing with
the space before the asterisk, causing for a bad visual appearance of a double space in these cases.
Addresses #15489.
I attempted to use a literal space and not the symbol, but the compiler collapsed it for me.