Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drag-drop): dragged styling not being removed when exiting component with OnPush #15266

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(drag-drop): dragged styling not being removed when exiting component with OnPush #15266

merged 1 commit into from
Mar 20, 2019

Conversation

crisbeto
Copy link
Member

Fixes the dragged styling not being removed from a drop container, which is wrapped inside a component with OnPush change detection, when an item is dragged into a connected container.

Fixes #15233.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 21, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 21, 2019
@crisbeto crisbeto force-pushed the 15233/drag-drop-wrapped-cd branch from 455019e to 0854ddc Compare February 21, 2019 14:52
jelbourn
jelbourn approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 21, 2019
@crisbeto crisbeto force-pushed the 15233/drag-drop-wrapped-cd branch from 0854ddc to c6b17c6 Compare February 24, 2019 16:43
@crisbeto
fix(drag-drop): dragged styling not being removed when exiting compon…
d869f08 
…ent with OnPush

Fixes the dragged styling not being removed from a drop container, which is wrapped inside a component with `OnPush` change detection, when an item is dragged into a connected container.

Fixes angular#15233.
@crisbeto crisbeto force-pushed the 15233/drag-drop-wrapped-cd branch from c6b17c6 to d869f08 Compare March 8, 2019 23:17
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@andrewseguin andrewseguin merged commit 9bbbb80 into angular:master Mar 20, 2019
@andrewseguin andrewseguin added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels Mar 25, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk-drop-list-dragging not removed when exiting drop area
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin