Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drag-drop): disabled value not being synced to drop list ref #15065

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 2, 2019

Fixes the input value from the CdkDropList directive not being synced to the DropListRef.

Note: this didn't really break anything, because we have some logic for syncing the disabled value in CdkDrag as well, hence why all the tests are passing. These changes are here primarily to ensure that things are consistent and so that we don't run into weird issues in the future.

Fixes the input value from the `CdkDropList` directive not being synced to the `DropListRef`.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 2, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 2, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 20, 2019
@jelbourn jelbourn merged commit 1aafdbe into angular:master Feb 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants