Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ripples): support updating global ripple options at runtime #14705

Merged
merged 2 commits into from
Jan 16, 2019
Merged

feat(ripples): support updating global ripple options at runtime #14705

merged 2 commits into from
Jan 16, 2019

Conversation

devversion
Copy link
Member

  • Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime.

Closes #9729

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 2, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 2, 2019
@devversion devversion added target: minor This PR is targeted for the next minor release and removed cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release labels Jan 2, 2019
@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 2, 2019
@devversion devversion force-pushed the feat/disable-ripples-runtime branch from bdc9238 to e32f201 Compare January 2, 2019 19:19
crisbeto
crisbeto reviewed Jan 3, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good, but is it really something we'd want to support? I don't know how common it would be for an app to want to disable/enable ripples after it has been initialized.

@devversion
Copy link
Member Author

devversion commented Jan 3, 2019 •
edited
Loading

@crisbeto Since this is already possible right now, but just breaks for our custom MatRipple targets (chips, tab links), it's not really involving any changes to the MatRipple implementation at all.

Also since it has been requested and I personally think it's valuable and didn't even require some changes to MatRipple on its own, it should be good to document and test this.

@devversion
feat(ripples): support updating global ripple options at runtime
8a93ac9 
* Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime.

Closes angular#9729
@devversion
fixup! feat(ripples): support updating global ripple options at runtime
665c3ea 
Address feedback
@devversion devversion force-pushed the feat/disable-ripples-runtime branch from e32f201 to 665c3ea Compare January 9, 2019 18:17
jelbourn
jelbourn approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@vivian-hu-zz vivian-hu-zz merged commit 4f755cf into angular:master Jan 16, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@devversion @s2-abdo
feat(ripples): support updating global ripple options at runtime (ang…
b0098a5 
…ular#14705)

* feat(ripples): support updating global ripple options at runtime

* Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime.

Closes angular#9729

* fixup! feat(ripples): support updating global ripple options at runtime

Address feedback
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@devversion @s2-abdo
feat(ripples): support updating global ripple options at runtime (ang…
f42cf09 
…ular#14705)

* feat(ripples): support updating global ripple options at runtime

* Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime.

Closes angular#9729

* fixup! feat(ripples): support updating global ripple options at runtime

Address feedback
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] ripples: dynamically enable/disable all interaction ripples
5 participants
@devversion @googlebot @jelbourn @crisbeto @vivian-hu-zz