feat(drag-drop): add class to indicate whether a container can receiv… #14532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e an item Adds the `cdk-drop-list-receiving` class to drop containers that are able to receive the item that is currently being dragged. This class can be used to indicate to the user where they can drop an item. Fixes angular#14439.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…e an item (angular#14532) Adds the `cdk-drop-list-receiving` class to drop containers that are able to receive the item that is currently being dragged. This class can be used to indicate to the user where they can drop an item. Fixes angular#14439.
devversion
added a commit
to devversion/material2
that referenced
this pull request
May 28, 2019
Currently when someone uses single quote import declarations in their project and the `ng update` migration for Material runs, the Material imports are rewritten into multiple imports referring to individual secondary entry-points, but the actual existing quote style is ignored. This means that the linter can sometimes complain after the migration has been performed. Ideally we'd run the tslint fix task after the migration ran in order to fix all lint rule failures which are specific to the given project, but this is not a best-practice yet and we need to decide on the CLI-side whether the CLI should automatically run the fixers after generator/migration schematics ran. See: angular/angular-cli#14532 Unfortunately we can't do the same thing for the whitespace within the `NamedImports` declaration because the whitespace for object literal expressions is hard-coded. See: https://github.com/microsoft/TypeScript/blob/6a559e37ee0d660fcc94f086a34370e79e94b17a/src/compiler/emitter.ts#L3796-L3797 (`emitObjectLiteralExpression` does not allow configuring the format flags) Fixes angular#14532
jelbourn
pushed a commit
that referenced
this pull request
May 28, 2019
…#16131) Currently when someone uses single quote import declarations in their project and the `ng update` migration for Material runs, the Material imports are rewritten into multiple imports referring to individual secondary entry-points, but the actual existing quote style is ignored. This means that the linter can sometimes complain after the migration has been performed. Ideally we'd run the tslint fix task after the migration ran in order to fix all lint rule failures which are specific to the given project, but this is not a best-practice yet and we need to decide on the CLI-side whether the CLI should automatically run the fixers after generator/migration schematics ran. See: angular/angular-cli#14532 Unfortunately we can't do the same thing for the whitespace within the `NamedImports` declaration because the whitespace for object literal expressions is hard-coded. See: https://github.com/microsoft/TypeScript/blob/6a559e37ee0d660fcc94f086a34370e79e94b17a/src/compiler/emitter.ts#L3796-L3797 (`emitObjectLiteralExpression` does not allow configuring the format flags) Fixes #14532
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…angular#16131) Currently when someone uses single quote import declarations in their project and the `ng update` migration for Material runs, the Material imports are rewritten into multiple imports referring to individual secondary entry-points, but the actual existing quote style is ignored. This means that the linter can sometimes complain after the migration has been performed. Ideally we'd run the tslint fix task after the migration ran in order to fix all lint rule failures which are specific to the given project, but this is not a best-practice yet and we need to decide on the CLI-side whether the CLI should automatically run the fixers after generator/migration schematics ran. See: angular/angular-cli#14532 Unfortunately we can't do the same thing for the whitespace within the `NamedImports` declaration because the whitespace for object literal expressions is hard-coded. See: https://github.com/microsoft/TypeScript/blob/6a559e37ee0d660fcc94f086a34370e79e94b17a/src/compiler/emitter.ts#L3796-L3797 (`emitObjectLiteralExpression` does not allow configuring the format flags) Fixes angular#14532
|
Is there a way we can keep this cdk-drop-list-receiving class applied to the CdkDropList even while dragging? Once the CdkDrag gets over the container, the class is removed and replaced with the .cdk-drop-list-dragging. Can we keep both classes? |
|
@MNorgren I feel like that could be confusing. Once the item is inside a new container, the container isn't really receiving anymore, it has received the item already. If you want to capture both states you can target both the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
cdk-drop-list-receivingclass to drop containers that are able to receive the item that is currently being dragged. This class can be used to indicate to the user where they can drop an item.Fixes #14439.