Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" #14396

Merged

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Dec 5, 2018

Reverts #13774

@mmalerba mmalerba requested a review from crisbeto as a code owner December 5, 2018 22:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 5, 2018
@mmalerba mmalerba merged commit aa17fbd into master Dec 5, 2018
mmalerba added a commit that referenced this pull request Dec 5, 2018
…display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.
mmalerba added a commit that referenced this pull request Dec 5, 2018
… in trigger" (#14398)

* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"

This reverts commit 904a5ea.
@mmalerba mmalerba deleted the revert-13774-13734/autocomplete-auto-active-float-label branch December 10, 2018 22:19
mmalerba added a commit that referenced this pull request Dec 10, 2018
…correctly if the floating label is disabled" (#14396)

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.
mmalerba added a commit that referenced this pull request Dec 10, 2018
… in trigger" (#14398)

* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"

This reverts commit 904a5ea.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…correctly if the floating label is disabled" (angular#14396)

* Revert "fix(drag-drop): error on touch end (angular#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (angular#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (angular#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#13774)"

This reverts commit c99c512.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
… in trigger" (angular#14398)

* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (angular#14396)"

This reverts commit aa17fbd.

* Revert "fix(drag-drop): error on touch end (angular#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (angular#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (angular#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (angular#13774)"

This reverts commit c99c512.

* Revert "fix(autocomplete): update template when changing autocomplete in trigger (angular#13814)"

This reverts commit 904a5ea.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants