Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(focus-trap): warn if initial element is not focusable #13960

Merged
merged 1 commit into from
Nov 7, 2018
Merged

fix(focus-trap): warn if initial element is not focusable #13960

merged 1 commit into from
Nov 7, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 3, 2018

Currently if the consumer sets the cdkFocusInitial group on a non-focusable element, nothing will happen. These changes add a warning if the app is running in dev mode.

Relates to #13953.

@crisbeto
fix(focus-trap): warn if initial element is not focusable
7db4638 
Currently if the consumer sets the `cdkFocusInitial` group on a non-focusable element, nothing will happen. These changes add a warning if the app is running in dev mode.

Relates to angular#13953.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 3, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 3, 2018
jelbourn
jelbourn approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm generally hesitant to add warnings like this because the code still ends up in the production bundle, but I think this case warrants it.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2018
@vivian-hu-zz vivian-hu-zz merged commit 27347b5 into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@crisbeto
fix(focus-trap): warn if initial element is not focusable (#13960)
3026138 
Currently if the consumer sets the `cdkFocusInitial` group on a non-focusable element, nothing will happen. These changes add a warning if the app is running in dev mode.

Relates to #13953.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @vivian-hu-zz