fix(checkbox): don't show hover ripples on touch devices #13700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
devversion,
jelbourn and
josephperrott
as code owners
googlebot
added
the
cla: yes
This was referenced Oct 20, 2018
crisbeto
force-pushed
the
13675/checkbox-touch-hover-ripples
branch
from
31d4564 to
4f52c4f
Compare
josephperrott
added
blocked
josephperrott
removed
the
action: merge
|
|
jelbourn
removed
blocked
crisbeto
force-pushed
the
13675/checkbox-touch-hover-ripples
branch
from
4f52c4f to
bf830d3
Compare
On touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples. Fixes angular#13675.
crisbeto
force-pushed
the
13675/checkbox-touch-hover-ripples
branch
from
bf830d3 to
192eb3f
Compare
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
On touch devices `:hover` styling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples. Fixes angular#13675.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On touch devices
:hoverstyling persists after the user has tapped. These changes hide the persistent ripple if the user isn't able to hover, in order to avoid confusion with the other ripples.Fixes #13675.