Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): tree folder icons do not have enough contrast #13462

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Oct 5, 2018

addresses aXe/Lighthouse a11y audit failures

This raises the Lighthouse a11y score for all schematics combined from 88 to 94. The other 6 missing points are from #11083 and #11083 (comment).

addresses aXe/Lighthouse a11y audit failures
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2018
@Splaktar Splaktar added target: major This PR is targeted for the next major release pr: merge safe labels Oct 5, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 5, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 4a0eb2b into master Oct 10, 2018
@Splaktar Splaktar deleted the fixTreeSchematicA11y branch October 10, 2018 18:34
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants