fix(drag-drop): events fired multiple times for short drag sequences on touch devices #13135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
I finally got drag-drop enabled in Google, so back to not being merge-safe |
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
13125/drag-drop-multiple-events
branch
from
619794f to
8f8bd6d
Compare
crisbeto
added
target: patch
crisbeto
force-pushed
the
13125/drag-drop-multiple-events
branch
from
8f8bd6d to
2b87abb
Compare
crisbeto
force-pushed
the
13125/drag-drop-multiple-events
branch
from
2b87abb to
21690bc
Compare
…on touch devices Fixes the `started` and `ended` events being fired multiple times for short drag sequences on touch devices. The issue comes from the fact that we listen both for mouse and touch events, which means that we also pick up the fake events that are fired by mobile browsers. Fixes angular#13125.
crisbeto
force-pushed
the
13125/drag-drop-multiple-events
branch
from
21690bc to
2cfca06
Compare
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
…on touch devices (#13135) Fixes the `started` and `ended` events being fired multiple times for short drag sequences on touch devices. The issue comes from the fact that we listen both for mouse and touch events, which means that we also pick up the fake events that are fired by mobile browsers. Fixes #13125.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
startedandendedevents being fired multiple times for short drag sequences on touch devices. The issue comes from the fact that we listen both for mouse and touch events, which means that we also pick up the fake events that are fired by mobile browsers.Fixes #13125.