Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk/overlay): add start and end positions to GlobalPositionStrategy #12007

Merged
merged 1 commit into from
Feb 27, 2022
Merged

feat(cdk/overlay): add start and end positions to GlobalPositionStrategy #12007

merged 1 commit into from
Feb 27, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 2, 2018

  • Makes some things easier to follow in the GlobalPositionStrategy.
  • Adds the ability to position a global overlay to the start and end of the viewport, based on its layout direction.
  • Fixes the offset in the center position always being from the left.
  • Adds better docs for the various methods.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Jul 2, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 2, 2018
@crisbeto crisbeto force-pushed the global-position-start-end branch from b3eb690 to f6b7c10 Compare July 3, 2018 03:26
@crisbeto
Copy link
Member Author

crisbeto commented Jul 3, 2018

Addressed the feedback @josephperrott.

josephperrott
josephperrott approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add the merge ready when its ready to go

src/cdk/overlay/position/global-position-strategy.spec.ts Show resolved Hide resolved
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 3, 2018
@crisbeto crisbeto force-pushed the global-position-start-end branch from f6b7c10 to 02fdfae Compare July 3, 2018 16:09
@ngbot
Copy link

ngbot bot commented Sep 21, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the global-position-start-end branch from 02fdfae to 029297c Compare September 22, 2018 09:58
@crisbeto crisbeto force-pushed the global-position-start-end branch from 029297c to 60ea22f Compare January 3, 2019 15:34
@crisbeto crisbeto force-pushed the global-position-start-end branch from 60ea22f to 45076bc Compare February 16, 2019 17:56
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@crisbeto crisbeto force-pushed the global-position-start-end branch from 45076bc to 48db19b Compare June 12, 2019 19:33
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 12, 2019
@josephperrott josephperrott removed their assignment Oct 15, 2019
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@crisbeto crisbeto force-pushed the global-position-start-end branch from 48db19b to e5f1fdc Compare October 13, 2020 14:48
@crisbeto crisbeto changed the title feat(overlay): add start and end positions to GlobalPositionStrategy feat(cdk/overlay): add start and end positions to GlobalPositionStrategy Oct 13, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@crisbeto crisbeto force-pushed the global-position-start-end branch from e5f1fdc to a663938 Compare February 27, 2022 10:11
@crisbeto crisbeto requested a review from a team as a code owner February 27, 2022 10:11
@crisbeto
feat(cdk/overlay): add start and end positions to GlobalPositionStrategy
7098a9b 
* Makes some things easier to follow in the `GlobalPositionStrategy`.
* Adds the ability to position a global overlay to the start and end of the viewport, based on its layout direction.
* Fixes the offset in the `center` position always being from the left.
* Adds better docs for the various methods.
@crisbeto crisbeto force-pushed the global-position-start-end branch from a663938 to 7098a9b Compare February 27, 2022 17:44
@crisbeto crisbeto merged commit c296084 into angular:master Feb 27, 2022
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 14, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crisbeto @josephperrott @jelbourn @googlebot @mmalerba @andrewseguin